[PATCH V9 5/9] nvmet: add bio get helper for different backends

[Chaitanya Kulkarni]

On 1/18/21 10:28 AM, Christoph Hellwig wrote:
> On Wed, Jan 13, 2021 at 05:03:05AM +0000, Chaitanya Kulkarni wrote:
>> On 1/11/21 23:33, Christoph Hellwig wrote:
>>> I'm not a huge fan of this helper, especially as it sets an end_io
>>> callback only for the allocated case, which is a weird calling
>>> convention.
>>>
>> The patch has a right documentation and that end_io is needed
>> for passthru case. To get rid of the weirdness I can remove
>> passthru case and make itend_io assign to inline and non-inline bio
>> to make it non-weired.
>>
>> Since this eliminates exactly identical lines of the code in atleast two
>> backend which we should try to use the helper in non-wried way.
> I really do not like helper that just eliminate "duplicate lines" vs
> encapsulating logic that makes sense one its own.
>
Okay, I'll drop it, next version.