fabrics connect cmd with a non-zero reserved value

[Engel, Amit]

Since the data is coming in the form of an sgl, the reserved bits that the spec defines are not really reserved.
I would expect that the spec will not mark the second byte of connect cmd as reserved
(These reserved bits are not cleared to 0h)

-----Original Message-----
From: Christoph Hellwig <hch at infradead.org> 
Sent: Thursday, January 14, 2021 7:36 PM
To: Sagi Grimberg
Cc: Engel, Amit; linux-nvme at lists.infradead.org; Anner, Ran; Frederick.Knight at netapp.com; Grupi, Elad
Subject: Re: fabrics connect cmd with a non-zero reserved value


[EXTERNAL EMAIL] 

On Wed, Jan 13, 2021 at 05:10:05PM -0800, Sagi Grimberg wrote:
> OK, now I see the issue.
> 
> This appears to me this would be an issue with the spec. As the 
> connect data (like any command payload) is coming in the form of an sgl.

Reserved fields in host to controller data structure may be checked, but may also not.  So we can verify anyting we think is to bogus to pass, but there is not requirement for the controller to check every reserved field or bit.