[PATCH V2 2/2] nvme: retry commands based on ACRE result

Minwoo Im minwoo.im.dev at gmail.com
Wed Jan 13 22:27:21 EST 2021


Hello,

> If acre is true and nvme_req(req)->status is nvme path error and
> blk_noretry_request(req) is true, we need return complete for REQ_FAILFAST_XX.
> Otherwise, connection process may takes long time in abnormal scenarios.
> We can do like this:
> 
> +    if (nvme_req(req)->ctrl->acre &&
> +        !nvme_is_path_error(nvme_req(req)->status) &&
> +        !blk_queue_dying(req->q))
> +        return RETRY;
> +
> +    if (blk_noretry_request(req))
> +        return COMPLETE;

Ah.. You're right.. I really appreciate for your review!
I will prepare the next patches.

Thank you!



More information about the Linux-nvme mailing list