[PATCH V2 2/2] nvme: retry commands based on ACRE result

[Minwoo Im]

Hello,

Thanks for your time!

On 21-01-13 14:20:34, Sagi Grimberg wrote:
> > Introduce acre flag for Advanced Command Retry Enable to controller
> > instance to decide whether to retry or not in error cases.  This flag is
> > set if Set Features for Host Behavior Support with ACRE bit set is
> > successfully done during reset_work.
> > 
> > This patch also fixes nvme_decide_disposition() because all the nvme
> > requests are initialized with REQ_FAILFAST_DRIVER to req->cmd_flags
> 
> You mean for passthru commands, nvme doesn't control this for other
> commands.
> 

Oh, I forgot to mention... Thanks for catching this.

> > so
> > that blk_noretry_request(req) is always true.  Check ctrl->acre first
> > and if it's not host path error, then it will be retried.
> 
> I suggest to split out this part to its own patch.
> 

Okay.  I will split it up to two patches:

  - Introducing ACRE flag to controller
  - Check ACRE flag in nvme_decide_disposition()

Thanks!