[PATCH V2 1/2] nvme: check all retry delay times in Identify Controller
Minwoo Im
minwoo.im.dev at gmail.com
Wed Jan 13 09:35:37 EST 2021
If none of Command Retry Delay Time(CRDT)s are set, then we can simply
skip to configure Advanced Command Retry Enable(ACRE).
CRDT selection will be made in Completion Queue Entry that controller
has responsibility to decide.
This patch checks all CRDT[0, 1, and 2] in Identify Controller data
structrure instead of checking the first one: CRDT[0] for cases that:
- CRDT[0] == 0, but CRDT[1 or 2] != 0
Signed-off-by: Minwoo Im <minwoo.im.dev at gmail.com>
---
drivers/nvme/host/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index fff49e544fdf..a8cee380b3c0 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2499,7 +2499,7 @@ static int nvme_configure_acre(struct nvme_ctrl *ctrl)
int ret;
/* Don't bother enabling the feature if retry delay is not reported */
- if (!ctrl->crdt[0])
+ if (!ctrl->crdt[0] && !ctrl->crdt[1] && !ctrl->crdt[2])
return 0;
host = kzalloc(sizeof(*host), GFP_KERNEL);
--
2.17.1
More information about the Linux-nvme
mailing list