[V3 0/4] nvmet: admin-cmd related cleanups and a fix

Chaitanya Kulkarni chaitanya.kulkarni at wdc.com
Tue Jan 12 16:14:06 EST 2021


Hi,

There are three functions where local variable ns is used instead of
using req->ns which leads to duplicate nvmet_put_namespace() calls.
We can just use req->ns and not the local variable to avoid duplicate
calls. First three patches fix that.

The first patch sets the right error status code when namespace is not
found in nvmet_execute_identify_ns().

I've tested this series with nvme blktests, all the testcases are
passing.

-ck

Changes from V2:-

1. Rebase and retest on the latest nvme-5.11.
2. Add ns status error patch at the front of the series.

Changes from V1:-

1. Rebase and retest on the latest nvme-5.11.

Chaitanya Kulkarni (4):
  nvmet: set right status on error in id-ns handler
  nvmet: remove extra variable in smart log nsid
  nvmet: remove extra variable in id-desclist
  nvmet: remove extra variable in identify ns

 drivers/nvme/target/admin-cmd.c | 74 ++++++++++++++++-----------------
 1 file changed, 36 insertions(+), 38 deletions(-)

# !./check
./check tests/nvme
nvme/002 (create many subsystems and test discovery)         [passed]
    runtime    ...  27.806s
nvme/003 (test if we're sending keep-alives to a discovery controller) [passed]
    runtime  10.143s  ...  10.136s
nvme/004 (test nvme and nvmet UUID NS descriptors)           [passed]
    runtime  1.697s  ...  1.730s
nvme/005 (reset local loopback target)                       [not run]
    nvme_core module does not have parameter multipath
nvme/006 (create an NVMeOF target with a block device-backed ns) [passed]
    runtime  0.115s  ...  0.113s
nvme/007 (create an NVMeOF target with a file-backed ns)     [passed]
    runtime  0.072s  ...  0.074s
nvme/008 (create an NVMeOF host with a block device-backed ns) [passed]
    runtime  1.740s  ...  1.720s
nvme/009 (create an NVMeOF host with a file-backed ns)       [passed]
    runtime  1.671s  ...  1.683s
nvme/010 (run data verification fio job on NVMeOF block device-backed ns) [passed]
    runtime  19.842s  ...  25.213s
nvme/011 (run data verification fio job on NVMeOF file-backed ns) [passed]
    runtime  232.526s  ...  257.846s
nvme/012 (run mkfs and data verification fio job on NVMeOF block device-backed ns) [passed]
    runtime  46.703s  ...  47.453s
nvme/013 (run mkfs and data verification fio job on NVMeOF file-backed ns) [passed]
    runtime  284.149s  ...  249.408s
nvme/014 (flush a NVMeOF block device-backed ns)             [passed]
    runtime  21.989s  ...  22.446s
nvme/015 (unit test for NVMe flush for file backed ns)       [passed]
    runtime  19.330s  ...  18.614s
nvme/016 (create/delete many NVMeOF block device-backed ns and test discovery) [passed]
    runtime  16.634s  ...  16.945s
nvme/017 (create/delete many file-ns and test discovery)     [passed]
    runtime  16.120s  ...  17.179s
nvme/018 (unit test NVMe-oF out of range access on a file backend) [passed]
    runtime  1.665s  ...  1.676s
nvme/019 (test NVMe DSM Discard command on NVMeOF block-device ns) [passed]
    runtime  1.692s  ...  1.701s
nvme/020 (test NVMe DSM Discard command on NVMeOF file-backed ns) [passed]
    runtime  1.655s  ...  1.662s
nvme/021 (test NVMe list command on NVMeOF file-backed ns)   [passed]
    runtime  1.648s  ...  1.666s
nvme/022 (test NVMe reset command on NVMeOF file-backed ns)  [passed]
    runtime  2.086s  ...  2.099s
nvme/023 (test NVMe smart-log command on NVMeOF block-device ns) [passed]
    runtime  1.683s  ...  1.699s
nvme/024 (test NVMe smart-log command on NVMeOF file-backed ns) [passed]
    runtime  1.653s  ...  1.659s
nvme/025 (test NVMe effects-log command on NVMeOF file-backed ns) [passed]
    runtime  1.653s  ...  1.649s
nvme/026 (test NVMe ns-descs command on NVMeOF file-backed ns) [passed]
    runtime  1.663s  ...  1.658s
nvme/027 (test NVMe ns-rescan command on NVMeOF file-backed ns) [passed]
    runtime  1.661s  ...  1.665s
nvme/028 (test NVMe list-subsys command on NVMeOF file-backed ns) [passed]
    runtime  1.659s  ...  1.663s
nvme/029 (test userspace IO via nvme-cli read/write interface) [passed]
    runtime  2.009s  ...  2.025s
nvme/030 (ensure the discovery generation counter is updated appropriately) [passed]
    runtime  0.316s  ...  0.317s
nvme/031 (test deletion of NVMeOF controllers immediately after setup) [passed]
    runtime  5.608s  ...  5.559s
nvme/038 (test deletion of NVMeOF subsystem without enabling) [passed]
    runtime  0.045s  ...  0.046s

-- 
2.22.1




More information about the Linux-nvme mailing list