[PATCH v2] nvme: Check the PRINFO bit and the Metadata size before deciding the host buffer length
Revanth Rajashekar
revanth.rajashekar at intel.com
Tue Jan 12 12:29:41 EST 2021
According to NVMe spec v1.4, section 8.3.1, the PRINFO bit and
the metadata size play a vital role in deteriming the host buffer size.
If PRIFNO bit is set and MS==8, the host doesn't add the metadata buffer,
instead the controller adds it.
Changes from v1:
1. Remove the definition 'NVME_PRINFO_CTRL_BIT'
2. Remove variable 'control'
3. Remove test_bit and check the bit with the CPU arch's native endianness
Signed-off-by: Revanth Rajashekar <revanth.rajashekar at intel.com>
---
drivers/nvme/host/core.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index f320273fc672..03261e0abdcc 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1546,6 +1546,11 @@ static int nvme_submit_io(struct nvme_ns *ns, struct nvme_user_io __user *uio)
meta_len = (io.nblocks + 1) * ns->ms;
metadata = nvme_to_user_ptr(io.metadata);
+ if (io.control & NVME_RW_PRINFO_PRACT && ns->ms == 8) {
+ meta_len = 0;
+ metadata = NULL;
+ }
+
if (ns->features & NVME_NS_EXT_LBAS) {
length += meta_len;
meta_len = 0;
--
2.17.1
More information about the Linux-nvme
mailing list