[PATCH v3] RDMA/siw: Fix handling of zero-sized Read and Receive Queues.

Jason Gunthorpe jgg at nvidia.com
Thu Jan 7 14:38:38 EST 2021


On Wed, Dec 16, 2020 at 12:00:00PM +0100, Bernard Metzler wrote:
> @@ -933,6 +937,7 @@ int siw_activate_tx(struct siw_qp *qp)
>  
>  		goto out;
>  	}
> +no_irq:
>  	sqe = sq_get_next(qp);
>  	if (sqe) {

Can you please arrange this without the spaghetti goto's? goto is ok
for error unwind at the tail of the function, but should not be used
willy nilly. Move some of this into functions, use normal if
statements, etc.

Jason



More information about the Linux-nvme mailing list