[PATCHv4 0/4] Fixup return value for nvme_submit_sync_cmd()

Hannes Reinecke hare at suse.de
Fri Feb 26 02:17:24 EST 2021


Hi all,

here are some small patches for fixing up the return value of
nvme_submit_sync_cmd().
As Keith correctly noted, nvme_submit_sync_cmd() should be returning
an error if the command could not be performed; however, currently
only pci does that.
So we need to fix up nvme_cancel_request() to return an -EINTR
on any pending sync commands during reset.
And modify nvme-fc to return the same nvme status after timing out
or cancelling requests.

As usual, comments and reviews are welcome.

Changes to v3:
- Dropped patch to change the status code for aborted commands
- Dropped patch to set -ETIMEDOUT on timed out commands
- Include reviews from Chao Leng

Changes to v2:
- Include reviews from Sagi
- Simplify error logic from nvme_validate_ns()

Changes to v1:
- Include reviews from Daniel
- Include changes for nvme-fc to return the same status as the
  other transports

Hannes Reinecke (4):
  nvme: simplify error logic in nvme_validate_ns()
  nvme: add NVME_REQ_CANCELLED flag in nvme_cancel_request()
  nvme-fc: set NVME_REQ_CANCELLED in nvme_fc_terminate_exchange()
  nvme-fc: return NVME_SC_HOST_ABORTED_CMD when a command has been
    aborted

 drivers/nvme/host/core.c | 9 +++++----
 drivers/nvme/host/fc.c   | 3 ++-
 2 files changed, 7 insertions(+), 5 deletions(-)

-- 
2.29.2




More information about the Linux-nvme mailing list