[PATCH V2 0/6] nvmet: cleanup and status, error log fix

[Chaitanya Kulkarni]

Hi,

This removes duplicate status value assignments, unnecessary function
parameters and fixes the error log page update. Last patch also
removes the spaces where tabs are expected.

-ck

V1->V2:

1. Remove the patch to set the status variable under if at the error.
2. Move the error log page update into nvmet_alloc_ctrl().
3. Add a patch to replace the spaces with tabs.

Chaitanya Kulkarni (6):
  nvmet: remove duplicate status assignment
  nvmet: update error log page in nvmet_alloc_ctrl()
  nvmet: remove unnecessary function parameters
  nvmet: remove unnecessary function parameter
  nvmet: remove unnecessary function parameters
  nvmet: replace white spaces with tabs

 drivers/nvme/target/admin-cmd.c   |  4 +--
 drivers/nvme/target/core.c        | 58 +++++++++++++++----------------
 drivers/nvme/target/fabrics-cmd.c | 19 ++++------
 drivers/nvme/target/nvmet.h       | 10 +++---
 4 files changed, 43 insertions(+), 48 deletions(-)

# ./check tests/nvme/
nvme/002 (create many subsystems and test discovery)         [passed]
    runtime  36.789s  ...  37.383s
nvme/003 (test if we're sending keep-alives to a discovery controller) [passed]
    runtime  10.177s  ...  10.164s
nvme/004 (test nvme and nvmet UUID NS descriptors)           [passed]
    runtime  1.743s  ...  1.739s
nvme/005 (reset local loopback target)                       [not run]
    nvme_core module does not have parameter multipath
nvme/006 (create an NVMeOF target with a block device-backed ns) [passed]
    runtime  0.141s  ...  0.137s
nvme/007 (create an NVMeOF target with a file-backed ns)     [passed]
    runtime  0.096s  ...  0.092s
nvme/008 (create an NVMeOF host with a block device-backed ns) [passed]
    runtime  1.756s  ...  1.760s
nvme/009 (create an NVMeOF host with a file-backed ns)       [passed]
    runtime  1.709s  ...  1.732s
nvme/010 (run data verification fio job on NVMeOF block device-backed ns) [passed]
    runtime  19.931s  ...  29.821s
nvme/011 (run data verification fio job on NVMeOF file-backed ns) [passed]
    runtime  267.604s  ...  282.232s
nvme/012 (run mkfs and data verification fio job on NVMeOF block device-backed ns) [passed]
    runtime  49.320s  ...  50.911s
nvme/013 (run mkfs and data verification fio job on NVMeOF file-backed ns) [passed]
    runtime  335.511s  ...  292.379s
nvme/014 (flush a NVMeOF block device-backed ns)             [passed]
    runtime  21.308s  ...  20.296s
nvme/015 (unit test for NVMe flush for file backed ns)       [passed]
    runtime  21.888s  ...  18.687s
nvme/016 (create/delete many NVMeOF block device-backed ns and test discovery) [passed]
    runtime  19.097s  ...  19.649s
nvme/017 (create/delete many file-ns and test discovery)     [passed]
    runtime  19.393s  ...  19.435s
nvme/018 (unit test NVMe-oF out of range access on a file backend) [passed]
    runtime  1.718s  ...  1.729s
nvme/019 (test NVMe DSM Discard command on NVMeOF block-device ns) [passed]
    runtime  1.747s  ...  1.786s
nvme/020 (test NVMe DSM Discard command on NVMeOF file-backed ns) [passed]
    runtime  1.700s  ...  1.704s
nvme/021 (test NVMe list command on NVMeOF file-backed ns)   [passed]
    runtime  1.702s  ...  1.745s
nvme/022 (test NVMe reset command on NVMeOF file-backed ns)  [passed]
    runtime  2.131s  ...  2.128s
nvme/023 (test NVMe smart-log command on NVMeOF block-device ns) [passed]
    runtime  1.739s  ...  1.761s
nvme/024 (test NVMe smart-log command on NVMeOF file-backed ns) [passed]
    runtime  1.708s  ...  1.717s
nvme/025 (test NVMe effects-log command on NVMeOF file-backed ns) [passed]
    runtime  1.692s  ...  1.703s
nvme/026 (test NVMe ns-descs command on NVMeOF file-backed ns) [passed]
    runtime  1.798s  ...  1.716s
nvme/027 (test NVMe ns-rescan command on NVMeOF file-backed ns) [passed]
    runtime  1.713s  ...  1.716s
nvme/028 (test NVMe list-subsys command on NVMeOF file-backed ns) [passed]
    runtime  1.695s  ...  1.723s
nvme/029 (test userspace IO via nvme-cli read/write interface) [passed]
    runtime  2.168s  ...  2.148s
nvme/030 (ensure the discovery generation counter is updated appropriately) [passed]
    runtime  0.379s  ...  0.381s
nvme/031 (test deletion of NVMeOF controllers immediately after setup) [passed]
    runtime  5.774s  ...  5.747s
nvme/038 (test deletion of NVMeOF subsystem without enabling) [passed]
    runtime  0.051s  ...  0.059s

-- 
2.22.1