[PATCH] nvme-rdma: fix crash for no IO queues

Chao Leng lengchao at huawei.com
Wed Feb 24 00:59:55 EST 2021



On 2021/2/24 7:21, Keith Busch wrote:
> On Tue, Feb 23, 2021 at 03:26:02PM +0800, Chao Leng wrote:
>> A crash happens when set feature(NVME_FEAT_NUM_QUEUES) timeout in nvme
>> over rdma(roce) reconnection, the reason is use the queue which is not
>> alloced.
>>
>> If it is not discovery and no io queues, the connection should fail.
> 
> If you're getting a timeout, we need to quit initialization. Hannes
> attempted making that status visible for fabrics here:
> 
>    http://lists.infradead.org/pipermail/linux-nvme/2021-January/022353.html
I know the patch. It can not solve the scenario: target may be an
attacker or the target behavior is incorrect.
If target return 0 io queues or return other error code, the crash will
still happen. We should not allow this to happen.
> 
> There's still some corner cases that need handling, though.
> .
> 



More information about the Linux-nvme mailing list