[PATCH] fabrics: permit kato int argument for discovery controllers

Hannes Reinecke hare at suse.de
Thu Feb 18 11:29:27 EST 2021


On 2/18/21 10:46 AM, Martin George wrote:
> Given discovery controllers can now accept integer arguments
> for kato, permit the same in build_options().
> 
> Signed-off-by: Martin George <marting at netapp.com>
> ---
>   fabrics.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/fabrics.c b/fabrics.c
> index 1880a5d..9cfe26a 100644
> --- a/fabrics.c
> +++ b/fabrics.c
> @@ -896,9 +896,8 @@ static int build_options(char *argstr, int max_len, bool discover)
>   	    (!discover &&
>   	      add_int_argument(&argstr, &max_len, "queue_size",
>   				cfg.queue_size, false)) ||
> -	    (!discover &&
> -	      add_int_argument(&argstr, &max_len, "keep_alive_tmo",
> -				cfg.keep_alive_tmo, false)) ||
> +	    add_int_argument(&argstr, &max_len, "keep_alive_tmo",
> +				cfg.keep_alive_tmo, false) ||
>   	    add_int_argument(&argstr, &max_len, "reconnect_delay",
>   				cfg.reconnect_delay, false) ||
>   	    add_int_argument(&argstr, &max_len, "ctrl_loss_tmo",
> 
Reviewed-by: Hannes Reinecke <hare at suse.de>

Martin, you probably have to resend it via a pull request to the github 
repository.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare at suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer



More information about the Linux-nvme mailing list