[PATCH] nvme-pci: mark Seagate Nytro XM1440 as QUIRK_NO_NS_DESC_LIST.

[Keith Busch]

On Tue, Feb 16, 2021 at 01:25:43PM +0100, jeinwag-nvme at marcapo.com wrote:
> From: Julian Einwag <jeinwag-nvme at marcapo.com>
> 
> The kernel fails to fully detect these SSDs, only the character devices are present:
> 
> [   10.785605] nvme nvme0: pci function 0000:04:00.0
> [   10.876787] nvme nvme1: pci function 0000:81:00.0
> [   13.198614] nvme nvme0: missing or invalid SUBNQN field.
> [   13.198658] nvme nvme1: missing or invalid SUBNQN field.
> [   13.206896] nvme nvme0: Shutdown timeout set to 20 seconds
> [   13.215035] nvme nvme1: Shutdown timeout set to 20 seconds
> [   13.225407] nvme nvme0: 16/0/0 default/read/poll queues
> [   13.233602] nvme nvme1: 16/0/0 default/read/poll queues
> [   13.239627] nvme nvme0: Identify Descriptors failed (8194)
> [   13.246315] nvme nvme1: Identify Descriptors failed (8194)
> 
> Adding the NVME_QUIRK_NO_NS_DESC_LIST fixes this problem.
> 
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205679

The code looks fine, but you need to add your Signed-off-by: tag in the
commit message.

Also, the first line in your commit log is too long and should be
wrapped to 72 characters.

> ---
>  drivers/nvme/host/pci.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 0045c5edf629..91cefa40543f 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -3233,7 +3233,8 @@ static const struct pci_device_id nvme_id_table[] = {
>  	{ PCI_DEVICE(0x126f, 0x2263),	/* Silicon Motion unidentified */
>  		.driver_data = NVME_QUIRK_NO_NS_DESC_LIST, },
>  	{ PCI_DEVICE(0x1bb1, 0x0100),   /* Seagate Nytro Flash Storage */
> -		.driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
> +		.driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY |
> +				NVME_QUIRK_NO_NS_DESC_LIST, },
>  	{ PCI_DEVICE(0x1c58, 0x0003),	/* HGST adapter */
>  		.driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
>  	{ PCI_DEVICE(0x1c58, 0x0023),	/* WDC SN200 adapter */
> --