[PATCH 1/2] nvmet: don't check iosqes,iocqes for discovery controllers

Sagi Grimberg sagi at grimberg.me
Wed Feb 10 17:34:54 EST 2021


>> +	if (!ctrl->subsys->type == NVME_NQN_DISC &&
> 
> I think the normal way to write this would be a !=.

:)

>> +	    (nvmet_cc_iosqes(ctrl->cc) != NVME_NVM_IOSQES ||
>> +	     nvmet_cc_iocqes(ctrl->cc) != NVME_NVM_IOCQES)) {
> 
> By the spec we'd need to check these are 0, but of course we'd break
> the existing Linux host.  Maybe throw in a comment?

Sure, I'll add it.



More information about the Linux-nvme mailing list