[PATCH] nvme: move NVMF_OPT_CTRL_LOSS_TMO to generic list of allowed options

[Hannes Reinecke]

On 2/5/21 5:25 PM, Christoph Hellwig wrote:
> On Fri, Feb 05, 2021 at 04:47:14PM +0100, Hannes Reinecke wrote:
>> Every single fabrics driver with the exception of loop is setting
>> NVMF_OPT_CTRL_LOSS_TMO, and recent nvme-cli has begun to set this
>> in the default options when create a discovery controller.
>> As it's not listed for loop connections to the loop controller will
>> fail.
>> So move it to the generic options to avoid this failure.
> 
> Well, the option doesn't really make sense for loop.  I think nvme-cli
> needs to be fixed to not set in this case.
> 
Neither does NVMF_OPT_FAIL_FAST_TMO, yet there it is ...

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare at suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer