[PATCH v2] nvme: avoid "(efault)" from nvme_sysfs_show_subsysnqn()

Chaitanya Kulkarni Chaitanya.Kulkarni at wdc.com
Mon Feb 1 20:34:37 EST 2021


On 2/1/21 17:00, mwilck at suse.com wrote:
> From: Martin Wilck <mwilck at suse.com>
>
> While a controller is still connecting, ctrl->subsys is NULL and
> thus reading the controller's "subsysnqn" sysfs attribute returns
> "(efault)". This happens all the time when user space processes
> "add" events for NVMe controller devices.
>
> Fix it by returning the nvmf_ctrl_options' subsysnqn attribute
> if ctrl->subsys isn't initialized yet.
>
> Signed-off-by: Martin Wilck <mwilck at suse.com>
Please add the version history from next time, as it helps others
to review the patch easily than the first-reviewer.

Looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>



More information about the Linux-nvme mailing list