[PATCH 1/1] nvme: Add verbose error logging

Sagi Grimberg sagi at grimberg.me
Mon Dec 13 01:28:36 PST 2021


> On Fri, Dec 10, 2021 at 08:56:48AM -0800, Keith Busch wrote:
>> I'm not sure having it be a new Kconfig option is a good idea since it
>> requires a recompile to enable/disable. Could this be toggled with a
>> static_key instead so we may disable/enable verbose logging at runtime?
> 
> We need to think about module size.  NVMe is not only used in big
> enterprise setups but also in deeply embedded scenarious these days.
> 
> I'm also not really convince of the usefulness (but also not strictly
> againt it), but if we support it it needs to be conditional.

Agree, the submitted patch made it conditional though.



More information about the Linux-nvme mailing list