[PATCH 1/1] Generate uevent on namespace AENs

Chaitanya Kulkarni Chaitanya.Kulkarni at wdc.com
Thu Apr 29 02:13:54 BST 2021


On 4/28/21 12:22, Keith Busch wrote:
> On Wed, Apr 28, 2021 at 06:51:48PM +0000, Chaitanya Kulkarni wrote:
>> On 4/27/21 05:03, Belanger, Martin wrote:
>>> Hi Chaitanya,
>>>
>>> I'm sorry, but I'm not sure what you mean by "proper commit description". What is "improper" about the description I submitted.
>>>
>>> Thanks,
>>> Martin
>> Commit log is as important as functionality :-
>>
>> 1. There is no commit log in the patch but in the cover letter.
>> 2. Subject line doesn't involve subsystem prefix.
> Also need the author's "Signed-off-by:" tag on the commit.
>

True, you need to run checkpatch.pl and make sure to fix all the warnings.



More information about the Linux-nvme mailing list