[PATCH v2] nvme: rdma/tcp: call nvme_mpath_stop() from reconnect workqueue

[Martin Wilck]

On Fri, 2021-04-23 at 17:50 +0200, Maurizio Lombardi wrote:
> Hello,
> 
> pá 23. 4. 2021 v 15:49 odesílatel <mwilck at suse.com> napsal:
> > From: Martin Wilck <mwilck at suse.com>
> > 
> > diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
> > index a0f00cb8f9f3..46287b4f4d10 100644
> > --- a/drivers/nvme/host/tcp.c
> > +++ b/drivers/nvme/host/tcp.c
> > @@ -2068,6 +2068,7 @@ static void
> > nvme_tcp_error_recovery_work(struct
> > work_struct *work)
> >                 return;
> >         }
> > 
> > +       nvme_mpath_stop(ctrl);
> >         nvme_tcp_reconnect_or_remove(ctrl);
> >  }
> > 
> 
> 
> Do you think it would make sense to call nvme_mpath_stop()
> inside nvme_tcp_reconnect_ctrl_work() too? 
> Right before it requeues itself by calling
> nvme_tcp_reconnect_or_remove(ctrl)?

Good point, probably yes. I'll have another look.

Thanks,
Martin