[PATCH 4/4] nvmet: make ver stable once connection established

[Chaitanya Kulkarni]

On 4/22/21 01:43, Max Gurtovoy wrote:
> On 4/20/2021 8:47 PM, Chaitanya Kulkarni wrote:
>> On 4/20/21 02:09, Max Gurtovoy wrote:
>>> -static ssize_t nvmet_subsys_attr_version_store(struct config_item *item,
>>> -					       const char *page, size_t count)
>>> +static ssize_t
>>> +nvmet_subsys_attr_version_store_locked(struct nvmet_subsys *subsys,
>>> +		const char *page, size_t count)
>>>   {
>> Seems like we lost the indentation in above line which was there previously.
> We added a new line since the line was > 80 chars.
>
> And we follow the conventions.

Original line has 5 tabs + spaces :-

-static ssize_t nvmet_subsys_attr_version_store(struct config_item *item,$
-^I^I^I^I^I       const char *page, size_t count)$

This change has 2 tabs no spaces, breaks the alignment of args:-

+nvmet_subsys_attr_version_store_locked(struct nvmet_subsys *subsys,$
+^I^Iconst char *page, size_t count)$

Following fits in 70 char(note the tabs before spaces):-

static ssize_t$
nvmet_subsys_attr_version_store_locked(struct nvmet_subsys *subsys,$
^I^I^I^I       const char *page, size_t count)$
It doesn't break convention, also keeps the alignment of args.

>