[PATCH V13 2/4] nvmet: add ZBD over ZNS backend support
Damien Le Moal
Damien.LeMoal at wdc.com
Thu Apr 8 09:15:43 BST 2021
On 2021/04/08 9:14, Chaitanya Kulkarni wrote:
> NVMe TP 4053 – Zoned Namespaces (ZNS) allows host software to
> communicate with a non-volatile memory subsystem using zones for NVMe
> protocol-based controllers. NVMeOF already support the ZNS NVMe
> Protocol compliant devices on the target in the passthru mode. There
> are Generic zoned block devices like Shingled Magnetic Recording (SMR)
> HDDs that are not based on the NVMe protocol.
>
> This patch adds ZNS backend to support the ZBDs for NVMeOF target.
>
> This support includes implementing the new command set NVME_CSI_ZNS,
> adding different command handlers for ZNS command set such as NVMe
> Identify Controller, NVMe Identify Namespace, NVMe Zone Append,
> NVMe Zone Management Send and NVMe Zone Management Receive.
>
> With the new command set identifier, we also update the target command
> effects logs to reflect the ZNS compliant commands.
>
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>
> ---
> drivers/nvme/target/Makefile | 1 +
> drivers/nvme/target/admin-cmd.c | 27 ++
> drivers/nvme/target/io-cmd-bdev.c | 35 ++-
> drivers/nvme/target/nvmet.h | 47 +++
> drivers/nvme/target/zns.c | 477 ++++++++++++++++++++++++++++++
> include/linux/nvme.h | 7 +
> 6 files changed, 585 insertions(+), 9 deletions(-)
> create mode 100644 drivers/nvme/target/zns.c
>
> diff --git a/drivers/nvme/target/Makefile b/drivers/nvme/target/Makefile
> index ebf91fc4c72e..9837e580fa7e 100644
> --- a/drivers/nvme/target/Makefile
> +++ b/drivers/nvme/target/Makefile
> @@ -12,6 +12,7 @@ obj-$(CONFIG_NVME_TARGET_TCP) += nvmet-tcp.o
> nvmet-y += core.o configfs.o admin-cmd.o fabrics-cmd.o \
> discovery.o io-cmd-file.o io-cmd-bdev.o
> nvmet-$(CONFIG_NVME_TARGET_PASSTHRU) += passthru.o
> +nvmet-$(CONFIG_BLK_DEV_ZONED) += zns.o
> nvme-loop-y += loop.o
> nvmet-rdma-y += rdma.o
> nvmet-fc-y += fc.o
> diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c
> index 176c8593d341..bf4876df624a 100644
> --- a/drivers/nvme/target/admin-cmd.c
> +++ b/drivers/nvme/target/admin-cmd.c
> @@ -179,6 +179,13 @@ static void nvmet_set_csi_nvm_effects(struct nvme_effects_log *log)
> log->iocs[nvme_cmd_write_zeroes] = cpu_to_le32(1 << 0);
> }
>
> +static void nvmet_set_csi_zns_effects(struct nvme_effects_log *log)
> +{
> + log->iocs[nvme_cmd_zone_append] = cpu_to_le32(1 << 0);
> + log->iocs[nvme_cmd_zone_mgmt_send] = cpu_to_le32(1 << 0);
> + log->iocs[nvme_cmd_zone_mgmt_recv] = cpu_to_le32(1 << 0);
> +}
> +
> static void nvmet_execute_get_log_cmd_effects_ns(struct nvmet_req *req)
> {
> struct nvme_effects_log *log;
> @@ -194,6 +201,15 @@ static void nvmet_execute_get_log_cmd_effects_ns(struct nvmet_req *req)
> case NVME_CSI_NVM:
> nvmet_set_csi_nvm_effects(log);
> break;
> + case NVME_CSI_ZNS:
> + if (!IS_ENABLED(CONFIG_BLK_DEV_ZONED)) {
> + status = NVME_SC_INVALID_IO_CMD_SET;
> + goto free;
> + }
> +
> + nvmet_set_csi_nvm_effects(log);
> + nvmet_set_csi_zns_effects(log);
> + break;
> default:
> status = NVME_SC_INVALID_LOG_PAGE;
> goto free;
> @@ -630,6 +646,13 @@ static u16 nvmet_execute_identify_desclist_csi(struct nvmet_req *req, off_t *o)
> {
> switch (req->ns->csi) {
> case NVME_CSI_NVM:
> + return nvmet_copy_ns_identifier(req, NVME_NIDT_CSI,
> + NVME_NIDT_CSI_LEN,
> + &req->ns->csi, o);
> + case NVME_CSI_ZNS:
> + if (!IS_ENABLED(CONFIG_BLK_DEV_ZONED))
> + return NVME_SC_INVALID_IO_CMD_SET;
> +
> return nvmet_copy_ns_identifier(req, NVME_NIDT_CSI,
> NVME_NIDT_CSI_LEN,
> &req->ns->csi, o);
> @@ -682,8 +705,12 @@ static void nvmet_execute_identify(struct nvmet_req *req)
> switch (req->cmd->identify.cns) {
> case NVME_ID_CNS_NS:
> return nvmet_execute_identify_ns(req);
> + case NVME_ID_CNS_CS_NS:
> + return nvmet_execute_identify_cns_cs_ns(req);
> case NVME_ID_CNS_CTRL:
> return nvmet_execute_identify_ctrl(req);
> + case NVME_ID_CNS_CS_CTRL:
> + return nvmet_execute_identify_cns_cs_ctrl(req);
> case NVME_ID_CNS_NS_ACTIVE_LIST:
> return nvmet_execute_identify_nslist(req);
> case NVME_ID_CNS_NS_DESC_LIST:
> diff --git a/drivers/nvme/target/io-cmd-bdev.c b/drivers/nvme/target/io-cmd-bdev.c
> index 9a8b3726a37c..1e54e7478735 100644
> --- a/drivers/nvme/target/io-cmd-bdev.c
> +++ b/drivers/nvme/target/io-cmd-bdev.c
> @@ -63,6 +63,14 @@ static void nvmet_bdev_ns_enable_integrity(struct nvmet_ns *ns)
> }
> }
>
> +void nvmet_bdev_ns_disable(struct nvmet_ns *ns)
> +{
> + if (ns->bdev) {
> + blkdev_put(ns->bdev, FMODE_WRITE | FMODE_READ);
> + ns->bdev = NULL;
> + }
> +}
> +
> int nvmet_bdev_ns_enable(struct nvmet_ns *ns)
> {
> int ret;
> @@ -86,15 +94,15 @@ int nvmet_bdev_ns_enable(struct nvmet_ns *ns)
> if (IS_ENABLED(CONFIG_BLK_DEV_INTEGRITY_T10))
> nvmet_bdev_ns_enable_integrity(ns);
>
> - return 0;
> -}
> -
> -void nvmet_bdev_ns_disable(struct nvmet_ns *ns)
> -{
> - if (ns->bdev) {
> - blkdev_put(ns->bdev, FMODE_WRITE | FMODE_READ);
> - ns->bdev = NULL;
> + if (bdev_is_zoned(ns->bdev)) {
> + if (!nvmet_bdev_zns_enable(ns)) {
> + nvmet_bdev_ns_disable(ns);
> + return -EINVAL;
> + }
> + ns->csi = NVME_CSI_ZNS;
> }
> +
> + return 0;
> }
>
> void nvmet_bdev_ns_revalidate(struct nvmet_ns *ns)
> @@ -102,7 +110,7 @@ void nvmet_bdev_ns_revalidate(struct nvmet_ns *ns)
> ns->size = i_size_read(ns->bdev->bd_inode);
> }
>
> -static u16 blk_to_nvme_status(struct nvmet_req *req, blk_status_t blk_sts)
> +u16 blk_to_nvme_status(struct nvmet_req *req, blk_status_t blk_sts)
> {
> u16 status = NVME_SC_SUCCESS;
>
> @@ -448,6 +456,15 @@ u16 nvmet_bdev_parse_io_cmd(struct nvmet_req *req)
> case nvme_cmd_write_zeroes:
> req->execute = nvmet_bdev_execute_write_zeroes;
> return 0;
> + case nvme_cmd_zone_append:
> + req->execute = nvmet_bdev_execute_zone_append;
> + return 0;
> + case nvme_cmd_zone_mgmt_recv:
> + req->execute = nvmet_bdev_execute_zone_mgmt_recv;
> + return 0;
> + case nvme_cmd_zone_mgmt_send:
> + req->execute = nvmet_bdev_execute_zone_mgmt_send;
> + return 0;
> default:
> return nvmet_report_invalid_opcode(req);
> }
> diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h
> index ab878fb96fbd..5e6514565f8c 100644
> --- a/drivers/nvme/target/nvmet.h
> +++ b/drivers/nvme/target/nvmet.h
> @@ -248,6 +248,10 @@ struct nvmet_subsys {
> unsigned int admin_timeout;
> unsigned int io_timeout;
> #endif /* CONFIG_NVME_TARGET_PASSTHRU */
> +
> +#ifdef CONFIG_BLK_DEV_ZONED
> + u8 zasl;
> +#endif /* CONFIG_BLK_DEV_ZONED */
> };
>
> static inline struct nvmet_subsys *to_subsys(struct config_item *item)
> @@ -528,6 +532,7 @@ void nvmet_ns_changed(struct nvmet_subsys *subsys, u32 nsid);
> void nvmet_bdev_ns_revalidate(struct nvmet_ns *ns);
> int nvmet_file_ns_revalidate(struct nvmet_ns *ns);
> void nvmet_ns_revalidate(struct nvmet_ns *ns);
> +u16 blk_to_nvme_status(struct nvmet_req *req, blk_status_t blk_sts);
>
> static inline u32 nvmet_rw_data_len(struct nvmet_req *req)
> {
> @@ -585,6 +590,48 @@ static inline struct nvme_ctrl *nvmet_passthru_ctrl(struct nvmet_subsys *subsys)
> }
> #endif /* CONFIG_NVME_TARGET_PASSTHRU */
>
> +#ifdef CONFIG_BLK_DEV_ZONED
> +bool nvmet_bdev_zns_enable(struct nvmet_ns *ns);
> +void nvmet_execute_identify_cns_cs_ctrl(struct nvmet_req *req);
> +void nvmet_execute_identify_cns_cs_ns(struct nvmet_req *req);
> +void nvmet_bdev_execute_zone_mgmt_recv(struct nvmet_req *req);
> +void nvmet_bdev_execute_zone_mgmt_send(struct nvmet_req *req);
> +void nvmet_bdev_execute_zone_append(struct nvmet_req *req);
> +#else /* CONFIG_BLK_DEV_ZONED */
> +static inline bool nvmet_bdev_zns_enable(struct nvmet_ns *ns)
> +{
> + return false;
> +}
> +static inline void
> +nvmet_execute_identify_cns_cs_ctrl(struct nvmet_req *req)
> +{
> + pr_err("unhandled identify cns %d on qid %d\n",
> + req->cmd->identify.cns, req->sq->qid);
> + req->error_loc = offsetof(struct nvme_identify, cns);
> + nvmet_req_complete(req, NVME_SC_INVALID_FIELD | NVME_SC_DNR);
> +}
> +static inline void
> +nvmet_execute_identify_cns_cs_ns(struct nvmet_req *req)
> +{
> + pr_err("unhandled identify cns %d on qid %d\n",
> + req->cmd->identify.cns, req->sq->qid);
> + req->error_loc = offsetof(struct nvme_identify, cns);
> + nvmet_req_complete(req, NVME_SC_INVALID_FIELD | NVME_SC_DNR);
> +}
> +static inline void
> +nvmet_bdev_execute_zone_mgmt_recv(struct nvmet_req *req)
> +{
> +}
> +static inline void
> +nvmet_bdev_execute_zone_mgmt_send(struct nvmet_req *req)
> +{
> +}
> +static inline void
> +nvmet_bdev_execute_zone_append(struct nvmet_req *req)
> +{
> +}
> +#endif /* CONFIG_BLK_DEV_ZONED */
> +
> static inline struct nvme_ctrl *
> nvmet_req_passthru_ctrl(struct nvmet_req *req)
> {
> diff --git a/drivers/nvme/target/zns.c b/drivers/nvme/target/zns.c
> new file mode 100644
> index 000000000000..308198dd580b
> --- /dev/null
> +++ b/drivers/nvme/target/zns.c
> @@ -0,0 +1,477 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * NVMe ZNS-ZBD command implementation.
> + * Copyright (C) 2021 Western Digital Corporation or its affiliates.
> + */
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +#include <linux/nvme.h>
> +#include <linux/blkdev.h>
> +#include "nvmet.h"
> +
> +/*
> + * We set the Memory Page Size Minimum (MPSMIN) for target controller to 0
> + * which gets added by 12 in the nvme_enable_ctrl() which results in 2^12 = 4k
> + * as page_shift value. When calculating the ZASL use shift by 12.
> + */
> +#define NVMET_MPSMIN_SHIFT 12
> +
> +static u16 nvmet_bdev_validate_zone_mgmt_recv(struct nvmet_req *req)
> +{
> + sector_t sect = nvmet_lba_to_sect(req->ns, req->cmd->zmr.slba);
> + u32 out_bufsize = (le32_to_cpu(req->cmd->zmr.numd) + 1) << 2;
> +
> + if (!bdev_is_zoned(req->ns->bdev))
> + return NVME_SC_INVALID_NS | NVME_SC_DNR;
> +
> + if (sect > get_capacity(req->ns->bdev->bd_disk)) {
> + req->error_loc = offsetof(struct nvme_zone_mgmt_recv_cmd, slba);
> + return NVME_SC_INVALID_FIELD | NVME_SC_DNR;
> + }
> +
> + /*
> + * Make sure out buffer size at least matches nvme report zone header.
> + * Reporting partial 64 bit nr_zones value can lead to unwanted side
> + * effects.
> + */
> + if (out_bufsize < sizeof(struct nvme_zone_report)) {
> + req->error_loc = offsetof(struct nvme_zone_mgmt_recv_cmd, numd);
> + return NVME_SC_INVALID_FIELD | NVME_SC_DNR;
> + }
> +
> + if (req->cmd->zmr.zra != NVME_ZRA_ZONE_REPORT) {
> + req->error_loc = offsetof(struct nvme_zone_mgmt_recv_cmd, zra);
> + return NVME_SC_INVALID_FIELD | NVME_SC_DNR;
> + }
> +
> + switch (req->cmd->zmr.pr) {
> + case 0:
> + case 1:
> + break;
> + default:
> + req->error_loc = offsetof(struct nvme_zone_mgmt_recv_cmd, pr);
> + return NVME_SC_INVALID_FIELD | NVME_SC_DNR;
> + }
> +
> + switch (req->cmd->zmr.zrasf) {
> + case NVME_ZRASF_ZONE_REPORT_ALL:
> + case NVME_ZRASF_ZONE_STATE_EMPTY:
> + case NVME_ZRASF_ZONE_STATE_IMP_OPEN:
> + case NVME_ZRASF_ZONE_STATE_EXP_OPEN:
> + case NVME_ZRASF_ZONE_STATE_CLOSED:
> + case NVME_ZRASF_ZONE_STATE_FULL:
> + case NVME_ZRASF_ZONE_STATE_READONLY:
> + case NVME_ZRASF_ZONE_STATE_OFFLINE:
> + break;
> + default:
> + req->error_loc =
> + offsetof(struct nvme_zone_mgmt_recv_cmd, zrasf);
> + return NVME_SC_INVALID_FIELD | NVME_SC_DNR;
> + }
> +
> + return NVME_SC_SUCCESS;
> +}
> +
> +static inline u8 nvmet_zasl(unsigned int zone_append_sects)
> +{
> + /*
> + * Zone Append Size Limit is the value expressed in the units of minimum
> + * memory page size (i.e. 12) and is reported power of 2.
> + */
> + return ilog2(zone_append_sects >> (NVMET_MPSMIN_SHIFT - 9));
> +}
> +
> +static inline bool nvmet_zns_update_zasl(struct nvmet_ns *ns)
> +{
> + struct request_queue *q = ns->bdev->bd_disk->queue;
> + u8 zasl = nvmet_zasl(queue_max_zone_append_sectors(q));
> +
> + if (ns->subsys->zasl)
> + return ns->subsys->zasl < zasl;
> +
> + ns->subsys->zasl = zasl;
> + return true;
> +}
> +
> +static int nvmet_bdev_validate_zns_zones_cb(struct blk_zone *z,
> + unsigned int i, void *data)
> +{
> + if (z->type == BLK_ZONE_TYPE_CONVENTIONAL)
> + return -EOPNOTSUPP;
> + return 0;
> +}
> +
> +static bool nvmet_bdev_has_conv_zones(struct block_device *bdev)
> +{
> + int ret;
> +
> + if (bdev->bd_disk->queue->conv_zones_bitmap)
> + return true;
> +
> + ret = blkdev_report_zones(bdev, 0, blkdev_nr_zones(bdev->bd_disk),
> + nvmet_bdev_validate_zns_zones_cb, NULL);
> +
> + return ret <= 0;
> +}
> +
> +bool nvmet_bdev_zns_enable(struct nvmet_ns *ns)
> +{
> + if (nvmet_bdev_has_conv_zones(ns->bdev))
> + return false;
> +
> + ns->blksize_shift = blksize_bits(bdev_logical_block_size(ns->bdev));
> +
> + if (!nvmet_zns_update_zasl(ns))
> + return false;
> + /*
> + * Generic zoned block devices may have a smaller last zone which is
> + * not supported by ZNS. Excludes zoned drives that have such smaller
> + * last zone.
> + */
> + return !(get_capacity(ns->bdev->bd_disk) &
> + (bdev_zone_sectors(ns->bdev) - 1));
> +}
> +
> +void nvmet_execute_identify_cns_cs_ctrl(struct nvmet_req *req)
> +{
> + u8 zasl = req->sq->ctrl->subsys->zasl;
> + struct nvmet_ctrl *ctrl = req->sq->ctrl;
> + struct nvme_id_ctrl_zns *id;
> + u16 status;
> +
> + if (req->cmd->identify.csi != NVME_CSI_ZNS) {
> + req->error_loc = offsetof(struct nvme_common_command, opcode);
> + status = NVME_SC_INVALID_OPCODE | NVME_SC_DNR;
> + goto out;
> + }
> +
> + id = kzalloc(sizeof(*id), GFP_KERNEL);
> + if (!id) {
> + status = NVME_SC_INTERNAL;
> + goto out;
> + }
> +
> + if (ctrl->ops->get_mdts)
> + id->zasl = min_t(u8, ctrl->ops->get_mdts(ctrl), zasl);
> + else
> + id->zasl = zasl;
> +
> + status = nvmet_copy_to_sgl(req, 0, id, sizeof(*id));
> +
> + kfree(id);
> +out:
> + nvmet_req_complete(req, status);
> +}
> +
> +void nvmet_execute_identify_cns_cs_ns(struct nvmet_req *req)
> +{
> + struct nvme_id_ns_zns *id_zns;
> + u64 zsze;
> + u16 status;
> +
> + if (req->cmd->identify.csi != NVME_CSI_ZNS) {
> + req->error_loc = offsetof(struct nvme_common_command, opcode);
> + status = NVME_SC_INVALID_OPCODE | NVME_SC_DNR;
> + goto out;
> + }
> +
> + if (le32_to_cpu(req->cmd->identify.nsid) == NVME_NSID_ALL) {
> + req->error_loc = offsetof(struct nvme_identify, nsid);
> + status = NVME_SC_INVALID_NS | NVME_SC_DNR;
> + goto out;
> + }
> +
> + id_zns = kzalloc(sizeof(*id_zns), GFP_KERNEL);
> + if (!id_zns) {
> + status = NVME_SC_INTERNAL;
> + goto out;
> + }
> +
> + status = nvmet_req_find_ns(req);
> + if (status) {
> + status = NVME_SC_INTERNAL;
> + goto done;
> + }
> +
> + if (!bdev_is_zoned(req->ns->bdev)) {
> + req->error_loc = offsetof(struct nvme_identify, nsid);
> + status = NVME_SC_INVALID_NS | NVME_SC_DNR;
> + goto done;
> + }
> +
> + nvmet_ns_revalidate(req->ns);
> + zsze = (bdev_zone_sectors(req->ns->bdev) << 9) >>
> + req->ns->blksize_shift;
> + id_zns->lbafe[0].zsze = cpu_to_le64(zsze);
> + id_zns->mor = cpu_to_le32(bdev_max_open_zones(req->ns->bdev));
> + id_zns->mar = cpu_to_le32(bdev_max_active_zones(req->ns->bdev));
> +
> +done:
> + status = nvmet_copy_to_sgl(req, 0, id_zns, sizeof(*id_zns));
> + kfree(id_zns);
> +out:
> + nvmet_req_complete(req, status);
> +}
> +
> +struct nvmet_report_zone_data {
> + struct nvme_zone_report *rz;
> + struct nvmet_ns *ns;
> + u64 nr_zones;
> + u8 zrasf;
> +};
> +
> +static int nvmet_bdev_report_zone_cb(struct blk_zone *z, unsigned i, void *d)
> +{
> + struct nvmet_report_zone_data *rz = d;
> + struct nvme_zone_descriptor *entries = rz->rz->entries;
> + struct nvmet_ns *ns = rz->ns;
> + static const unsigned int blk_zcond_to_nvme_zstate[] = {
> + [BLK_ZONE_COND_EMPTY] = NVME_ZRASF_ZONE_STATE_EMPTY,
> + [BLK_ZONE_COND_IMP_OPEN] = NVME_ZRASF_ZONE_STATE_IMP_OPEN,
> + [BLK_ZONE_COND_EXP_OPEN] = NVME_ZRASF_ZONE_STATE_EXP_OPEN,
> + [BLK_ZONE_COND_CLOSED] = NVME_ZRASF_ZONE_STATE_CLOSED,
> + [BLK_ZONE_COND_READONLY] = NVME_ZRASF_ZONE_STATE_READONLY,
> + [BLK_ZONE_COND_FULL] = NVME_ZRASF_ZONE_STATE_FULL,
> + [BLK_ZONE_COND_OFFLINE] = NVME_ZRASF_ZONE_STATE_OFFLINE,
> + };
> +
> + if (rz->zrasf == NVME_ZRASF_ZONE_REPORT_ALL)
> + goto record_zone;
> +
> + /*
> + * Make sure this zone condition's value is mapped to NVMe ZNS zone
> + * condition value.
> + */
> + if (z->cond > ARRAY_SIZE(blk_zcond_to_nvme_zstate) ||
> + !blk_zcond_to_nvme_zstate[z->cond])
> + return -EINVAL;
> +
> + /* filter zone by condition */
> + if (blk_zcond_to_nvme_zstate[z->cond] != rz->zrasf)
> + return 0;
> +
> +record_zone:
> +
> + entries[rz->nr_zones].zcap = nvmet_sect_to_lba(ns, z->capacity);
> + entries[rz->nr_zones].zslba = nvmet_sect_to_lba(ns, z->start);
> + entries[rz->nr_zones].wp = nvmet_sect_to_lba(ns, z->wp);
> + entries[rz->nr_zones].za = z->reset ? 1 << 2 : 0;
> + entries[rz->nr_zones].zs = z->cond << 4;
> + entries[rz->nr_zones].zt = z->type;
> +
> + rz->nr_zones++;
> +
> + return 0;
> +}
> +
> +unsigned long nvmet_req_nr_zones_from_slba(struct nvmet_req *req)
> +{
> + sector_t total_sect_from_slba;
> +
> + total_sect_from_slba = get_capacity(req->ns->bdev->bd_disk) -
> + nvmet_lba_to_sect(req->ns, req->cmd->zmr.slba);
> +
> + return total_sect_from_slba / bdev_zone_sectors(req->ns->bdev);
> +}
> +
> +unsigned long get_nr_zones_from_buf(struct nvmet_req *req, u32 out_bufsize)
> +{
> + if (out_bufsize < sizeof(struct nvme_zone_report))
> + return 0;
> +
> + return (out_bufsize - sizeof(struct nvme_zone_report)) /
> + sizeof(struct nvme_zone_descriptor);
> +}
> +
> +unsigned long bufsize_from_zones(unsigned long nr_zones)
> +{
> + return sizeof(struct nvme_zone_report) +
> + (sizeof(struct nvme_zone_descriptor) * nr_zones);
> +}
> +
> +void nvmet_bdev_execute_zone_mgmt_recv(struct nvmet_req *req)
> +{
> + unsigned long req_slba_nr_zones = nvmet_req_nr_zones_from_slba(req);
> + sector_t sect = nvmet_lba_to_sect(req->ns, req->cmd->zmr.slba);
> + u32 out_bufsize = (le32_to_cpu(req->cmd->zmr.numd) + 1) << 2;
> + unsigned long out_nr_zones = get_nr_zones_from_buf(req, out_bufsize);
> + int reported_zones;
> + u32 bufsize;
> + u16 status;
> + struct nvmet_report_zone_data data = {
> + .ns = req->ns,
> + .zrasf = req->cmd->zmr.zrasf
> + };
> +
> + status = nvmet_bdev_validate_zone_mgmt_recv(req);
> + if (status)
> + goto out;
> +
> + /* nothing to report */
> + if (!req_slba_nr_zones) {
> + status = NVME_SC_SUCCESS;
> + goto out;
> + }
> +
> + /*
> + * Allocate Zone descriptors based on the number of zones that fit from
> + * zmr.slba to disk capacity.
> + */
> + bufsize = bufsize_from_zones(req_slba_nr_zones);
> +
> + data.rz = __vmalloc(bufsize, GFP_KERNEL | __GFP_NORETRY | __GFP_ZERO);
> + if (!data.rz) {
> + status = NVME_SC_INTERNAL;
> + goto out;
> + }
Forgot: for slba == 0, this will allocate a buffer for all zones of the backend.
If that backend is an SMR drive with high capcity, we are talking about multi-MB
buffer here (e.g. 20TB drive has over 75000 zones x 64B -> 4.8 MB). A nasty host
sending lots of full report zones will end up consuming a lot of memory on the
target. So it may be better to cap busize to something resonable (say the
backend max_sectors) and do the report in a loop here. That will complicate a
little the code but not by much since the buffer filling is done in the cb and
that one does not need to change because of the loop.
> +
> + reported_zones = blkdev_report_zones(req->ns->bdev, sect,
> + req_slba_nr_zones,
> + nvmet_bdev_report_zone_cb, &data);
> + if (reported_zones < 0) {
> + status = NVME_SC_INTERNAL;
> + goto out_free_report_zones;
> + }
> +
> + if (req->cmd->zmr.pr) {
> + /*
> + * When partial bit is set nr_zones == zone desc transferred. So
> + * if captured zones are less than the nr zones that can fit in
> + * out buf, then trim the out_bufsize to avoid extra copy also
> + * update the number of zones that we can transfer in out buf.
> + */
> + if (data.nr_zones < out_nr_zones) {
> + out_bufsize = bufsize_from_zones(data.nr_zones);
> + out_nr_zones = data.nr_zones;
> + }
> + } else {
> + /*
> + * When partial bit is not set nr_zone == zones for which ZSLBA
> + * value is greater than or equal to the ZSLBA value of the zone
> + * specified by the SLBA value in the command and match the
> + * criteria in the Zone Receive Action Specific field ZRASF.
> + */
> + out_nr_zones = data.nr_zones;
> +
> + /* trim out_bufsize to avoid extra copy */
> + if (data.nr_zones < out_nr_zones)
> + out_bufsize = bufsize_from_zones(data.nr_zones);
> + }
> +
> + data.rz->nr_zones = cpu_to_le64(out_nr_zones);
> +
> + status = nvmet_copy_to_sgl(req, 0, data.rz, out_bufsize);
> +
> +out_free_report_zones:
> + kvfree(data.rz);
> +out:
> + nvmet_req_complete(req, status);
> +}
> +
> +void nvmet_bdev_execute_zone_mgmt_send(struct nvmet_req *req)
> +{
> + sector_t sect = nvmet_lba_to_sect(req->ns, req->cmd->zms.slba);
> + u16 status = NVME_SC_SUCCESS;
> + u8 zsa = req->cmd->zms.zsa;
> + sector_t nr_sects;
> + enum req_opf op;
> + int ret;
> + const unsigned int zsa_to_op[] = {
> + [NVME_ZONE_OPEN] = REQ_OP_ZONE_OPEN,
> + [NVME_ZONE_CLOSE] = REQ_OP_ZONE_CLOSE,
> + [NVME_ZONE_FINISH] = REQ_OP_ZONE_FINISH,
> + [NVME_ZONE_RESET] = REQ_OP_ZONE_RESET,
> + };
> +
> + if (zsa > ARRAY_SIZE(zsa_to_op)) {
> + status = NVME_SC_INVALID_FIELD;
> + goto out;
> + }
> +
> + op = zsa_to_op[zsa];
> +
> + if (req->cmd->zms.select_all) {
> + sect = 0;
> + nr_sects = get_capacity(req->ns->bdev->bd_disk);
> + } else {
> + sect = nvmet_lba_to_sect(req->ns, req->cmd->zms.slba);
> + nr_sects = bdev_zone_sectors(req->ns->bdev);
> + }
> +
> + ret = blkdev_zone_mgmt(req->ns->bdev, op, sect, nr_sects, GFP_KERNEL);
> + if (ret)
> + status = NVME_SC_INTERNAL;
> +out:
> + nvmet_req_complete(req, status);
> +}
> +
> +static void nvmet_bdev_zone_append_bio_done(struct bio *bio)
> +{
> + struct nvmet_req *req = bio->bi_private;
> +
> + req->cqe->result.u64 = nvmet_sect_to_lba(req->ns,
> + bio->bi_iter.bi_sector);
> + nvmet_req_complete(req, blk_to_nvme_status(req, bio->bi_status));
> + if (bio != &req->b.inline_bio)
> + bio_put(bio);
> +}
> +
> +void nvmet_bdev_execute_zone_append(struct nvmet_req *req)
> +{
> + sector_t sect = nvmet_lba_to_sect(req->ns, req->cmd->rw.slba);
> + u16 status = NVME_SC_SUCCESS;
> + unsigned int total_len = 0;
> + struct scatterlist *sg;
> + int ret = 0, sg_cnt;
> + struct bio *bio;
> +
> + /* Request is completed on len mismatch in nvmet_check_transter_len() */
> + if (!nvmet_check_transfer_len(req, nvmet_rw_data_len(req)))
> + return;
> +
> + if (!req->sg_cnt) {
> + nvmet_req_complete(req, 0);
> + return;
> + }
> +
> + if (req->transfer_len <= NVMET_MAX_INLINE_DATA_LEN) {
> + bio = &req->b.inline_bio;
> + bio_init(bio, req->inline_bvec, ARRAY_SIZE(req->inline_bvec));
> + } else {
> + bio = bio_alloc(GFP_KERNEL, req->sg_cnt);
> + }
> +
> + bio_set_dev(bio, req->ns->bdev);
> + bio->bi_iter.bi_sector = sect;
> + bio->bi_private = req;
> + bio->bi_end_io = nvmet_bdev_zone_append_bio_done;
> + bio->bi_opf = REQ_OP_ZONE_APPEND | REQ_SYNC | REQ_IDLE;
> + if (req->cmd->rw.control & cpu_to_le16(NVME_RW_FUA))
> + bio->bi_opf |= REQ_FUA;
> +
> + for_each_sg(req->sg, sg, req->sg_cnt, sg_cnt) {
> + struct page *p = sg_page(sg);
> + unsigned int l = sg->length;
> + unsigned int o = sg->offset;
> +
> + ret = bio_add_zone_append_page(bio, p, l, o);
> + if (ret != sg->length) {
> + status = NVME_SC_INTERNAL;
> + goto out_bio_put;
> + }
> +
> + total_len += sg->length;
> + }
> +
> + if (total_len != nvmet_rw_data_len(req)) {
> + status = NVME_SC_INTERNAL | NVME_SC_DNR;
> + goto out_bio_put;
> + }
> +
> + submit_bio(bio);
> + return;
> +
> +out_bio_put:
> + if (bio != &req->b.inline_bio)
> + bio_put(bio);
> + nvmet_req_complete(req, ret < 0 ? NVME_SC_INTERNAL : status);
> +}
> diff --git a/include/linux/nvme.h b/include/linux/nvme.h
> index c7ba83144d52..cb1197f1cfed 100644
> --- a/include/linux/nvme.h
> +++ b/include/linux/nvme.h
> @@ -944,6 +944,13 @@ struct nvme_zone_mgmt_recv_cmd {
> enum {
> NVME_ZRA_ZONE_REPORT = 0,
> NVME_ZRASF_ZONE_REPORT_ALL = 0,
> + NVME_ZRASF_ZONE_STATE_EMPTY = 0x01,
> + NVME_ZRASF_ZONE_STATE_IMP_OPEN = 0x02,
> + NVME_ZRASF_ZONE_STATE_EXP_OPEN = 0x03,
> + NVME_ZRASF_ZONE_STATE_CLOSED = 0x04,
> + NVME_ZRASF_ZONE_STATE_READONLY = 0x05,
> + NVME_ZRASF_ZONE_STATE_FULL = 0x06,
> + NVME_ZRASF_ZONE_STATE_OFFLINE = 0x07,
> NVME_REPORT_ZONE_PARTIAL = 1,
> };
>
>
--
Damien Le Moal
Western Digital Research
More information about the Linux-nvme
mailing list