[PATCH 17/20] nvme: query namespae identifiers before adding the namespace

[Niklas Cassel]

On Wed, Sep 30, 2020 at 11:44:11AM +0200, Niklas Cassel wrote:
> On Mon, Sep 28, 2020 at 02:34:59PM +0200, Christoph Hellwig wrote:
> > Check the namespace identifier list first thing when scanning namespaces.
> > This keeps the code to query the CSI common between the alloc and validate
> > path, and helps to structure the code better for multiple command set
> > support.
> > 
> > Signed-off-by: Christoph Hellwig <hch at lst.de>
> > ---
> >  drivers/nvme/host/core.c | 116 ++++++++++++++++++---------------------
> >  1 file changed, 53 insertions(+), 63 deletions(-)
> 
> For the subject of this patch:
> s/namespae/namespace
> 
> 
> 
> In your v1 series, you had a separate patch for:
> 
> "
> nvme: remove the namespace identifier verification in __nvme_validate_ns
> 
> None of the identifiers (including the new CSI) can cange over the life
> time of a namespace, so don't bother with the extra query here.
> "
> 
> which now seems to have been squashed with this patch.
> 
> Squashing it is fine, but perhaps you could add that information in this
> commit message?

Hm..

I now see that nvme_validate_or_alloc_ns() in v2 of this series does a
nvme_identify_ns_descs(), while nvme_validate_or_alloc_ns() in v1 doesnt.

I don't see a change log, but considering this, my suggestion that you
the above sentence from the squashed v1 commit no longer makes sense.

What was the reason for this change?


Kind regards,
Niklas