[RFC] nvme-mpath: delete disk after last connection

Christoph Hellwig hch at lst.de
Tue Sep 29 14:08:49 EDT 2020


On Tue, Sep 29, 2020 at 01:28:51AM -0700, Sagi Grimberg wrote:
> Something here is not clear to me, we are not really talking about "all
> paths down" but rather "all paths lost", which should take the gendisk
> down AFAIK.
>
> Keith, shouldn't we modify the gendisk reference manipulation in
> nvme_mpath_remove_disk instead of moving it to the call sites?
>
> I'm still unsure why we need a timer for this. If a path is removed
> (e.g. disconnected, we shouldn't keep the gendisk up).

True.  And I guess the right place to deal with timers is on how long
we are going to keep retrying (or at least the underlying disks alive).



More information about the Linux-nvme mailing list