[RFC] nvme-mpath: delete disk after last connection

Keith Busch kbusch at kernel.org
Mon Sep 28 10:11:06 EDT 2020


On Sun, Sep 27, 2020 at 08:07:09AM +0200, Christoph Hellwig wrote:
> On Sat, Sep 26, 2020 at 01:16:51PM +0200, Hannes Reinecke wrote:
> > I'm okay with that in general, but then again we might run into situations 
> > where an 'all paths down' scenario is actually expected (think of a 
> > temporary network outage on nvme-tcp).
> > So I guess we need to introduce an additional setting (queue_if_no_path?) 
> > to be specified during the initial connection.
> 
> The original design was pretty much intentional as and all paths down
> even usually is temporary.  So any change in behavior should be based
> on an optional instead of a change in default.  And I think the right
> way to do implement this would be a timer when to take the gendisk
> down, with the default remaining infinitity.

Ok, we can let the timer be an option for fabrics so it can be specific
to the subsystem you're connecting to. The timeout for pcie targets
probably has to be a module parameter, though.



More information about the Linux-nvme mailing list