[PATCH 0/7] nvme-fcloop: fix shutdown and improve logging

Hannes Reinecke hare at suse.de
Tue Sep 22 08:14:54 EDT 2020


Hi all,

there's a long-standing issue with fcloop that it triggers a use-after-free
when removing ports as the disconnect I/O is still running while the ports
are being removed.
This patchset fixes up this issue and also creates a device for each localport
and each nport; with that the logging is vastly improved as we now have
readable device names in the logging output and not "(NULL devuce *)".

Blocktests will be send separately.

As usual, comments and reviews are welcome.

Hannes Reinecke (7):
  nvme-fcloop: flush workqueue before calling
    nvme_fc_unregister_remoteport()
  nvmet-fc: use per-target workqueue when removing associations
  nvme-fcloop: use IDA for port ids
  nvmet-fc: use feature flag for virtual LLDD
  nvme-fc: use feature flag for virtual LLDD
  nvme-fcloop: use a device for nport
  nvme-fcloop: use a device for lport

 drivers/nvme/host/fc.c         |  93 ++++++++++++++++-------------
 drivers/nvme/target/fc.c       | 122 +++++++++++++++++++++++---------------
 drivers/nvme/target/fcloop.c   | 131 ++++++++++++++++++++++++++++++++---------
 include/linux/nvme-fc-driver.h |  12 ++++
 4 files changed, 241 insertions(+), 117 deletions(-)

-- 
2.16.4




More information about the Linux-nvme mailing list