[PATCH] nvme-loop: allow ctrl-loss-tmo for nvme-loop

Sagi Grimberg sagi at grimberg.me
Wed Sep 16 19:30:47 EDT 2020


>> I'd say we need to fix nvme-cli not passing optional parameters by
>> default...
> 
> I assume that we changed the nvme-cli to fix the issue and default
> behavior (i.e. expecting and setting the ctrl_loss_tmo).
> 
> Changing now again will break the fix in nvme-cli which requires this
> default behavior ?
> 
> I think it is easier fix with right comment documentation so we don't
> have to rely on the tools, plus it is only for nvme-loop which we use
> for development and testing but not in production.

Its going to keep breaking if nvme-cli keeps sending optional params
by default.

Don't care all that much, but it just seems backwards to me.



More information about the Linux-nvme mailing list