[PATCH] nvme-loop: allow ctrl-loss-tmo for nvme-loop

Chaitanya Kulkarni chaitanya.kulkarni at wdc.com
Tue Sep 15 19:04:56 EDT 2020


Update nvme-loop transport with NVMF_OPT_CTRL_LOSS_TMO in allowed ops.
Without this patch following command fails on my setup :-

nvme_fabrics: invalid parameter 'ctrl_loss_tmo=%d'

Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>
---

P.S. I've not bisected the root cause as this is happening after
latest pull, let me know if that is needed in this case.

HEAD :- 
commit af5ad17854f9 ("nvme-tcp: fix kconfig dependency warning when !CRYPTO")

---
 drivers/nvme/target/loop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/target/loop.c b/drivers/nvme/target/loop.c
index 0d6008cf66a2..f95cbe30e604 100644
--- a/drivers/nvme/target/loop.c
+++ b/drivers/nvme/target/loop.c
@@ -678,7 +678,7 @@ static struct nvmf_transport_ops nvme_loop_transport = {
 	.name		= "loop",
 	.module		= THIS_MODULE,
 	.create_ctrl	= nvme_loop_create_ctrl,
-	.allowed_opts	= NVMF_OPT_TRADDR,
+	.allowed_opts	= NVMF_OPT_TRADDR | NVMF_OPT_CTRL_LOSS_TMO,
 };
 
 static int __init nvme_loop_init_module(void)
-- 
2.22.1




More information about the Linux-nvme mailing list