[PATCH] nvme-pci: disable write zeros command for Intel 600P/P3100

[Eric Sandeen]

On 9/11/20 12:32 AM, Christoph Hellwig wrote:
> On Thu, Sep 10, 2020 at 04:18:50PM -0500, David Milburn wrote:
>> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
>> index 5e07d5628864..d31e298669a9 100644
>> --- a/drivers/nvme/host/pci.c
>> +++ b/drivers/nvme/host/pci.c
>> @@ -3153,7 +3153,8 @@ static const struct pci_device_id nvme_id_table[] = {
>>  	{ PCI_VDEVICE(INTEL, 0xf1a5),	/* Intel 600P/P3100 */
>>  		.driver_data = NVME_QUIRK_NO_DEEPEST_PS |
>>  				NVME_QUIRK_MEDIUM_PRIO_SQ |
>> -				NVME_QUIRK_NO_TEMP_THRESH_CHANGE },
>> +				NVME_QUIRK_NO_TEMP_THRESH_CHANGE |
>> +				NVME_QUIRK_DISABLE_WRITE_ZEROES, },
> 
> That's one amazingly buggy driver :)  Wasn't it the one with the
> corruptions with 512 byte writes as well that got fixed by the firmware
> upgrade?

Yes

> But yes, we'll have to work around it, so:
> 
> Reviewed-by: Christoph Hellwig <hch at lst.de>

Thanks Christoph

-Eric