[PATCH V2 1/6] nvme-core: use I/O timeout in submit sync cmd
Chaitanya Kulkarni
chaitanya.kulkarni at wdc.com
Thu Sep 3 20:16:21 EDT 2020
In the function __nvme_submit_sync_cmd() it uses ADMIN_TIMEOUT when
caller doesn't specify value for the timeout variable. This function is
also called from the NVMe commands contexts (nvme_pr_command()/
nvme_ns_report_zones()) where NVME_IO_TIMEOUT can be used instead of
ADMIN_TIMEOUT.
For now we don't set the request queue's queuedata for admin command.
When timeout is not specified based on the request queue's queuedata,
set Admin timeout else I/O timeout.
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>
---
drivers/nvme/host/core.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 5702a3843746..e6c980962d51 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -884,8 +884,12 @@ int __nvme_submit_sync_cmd(struct request_queue *q, struct nvme_command *cmd,
req = nvme_alloc_request(q, cmd, flags, qid);
if (IS_ERR(req))
return PTR_ERR(req);
-
- req->timeout = timeout ? timeout : ADMIN_TIMEOUT;
+ /*
+ * For now admin request queue's queue data == NULL, if that assumption
+ * changes it should reflect here.
+ */
+ if (!req->timeout)
+ req->timeout = q->queuedata ? NVME_IO_TIMEOUT : ADMIN_TIMEOUT;
if (buffer && bufflen) {
ret = blk_rq_map_kern(q, req, buffer, bufflen, GFP_KERNEL);
--
2.22.1
More information about the Linux-nvme
mailing list