[PATCH V2 01/12] nvme-core: annotate nvme_alloc_request()

Chaitanya Kulkarni Chaitanya.Kulkarni at wdc.com
Thu Sep 3 15:40:14 EDT 2020


On 9/3/20 09:17, Christoph Hellwig wrote:
> Before we start micro-optimzing this stuff I suspect we might want
> to just split the submit_cmd handlers so that we have a fast path
> and the rest.  We've grown a few too many arguments by now..
> 

Are you referring to any of this :-

1. Split nvmet_passthru_execute_cmd() into
    nvmet_passthru_execute_io_cmd() and
    nvmet_passthru_execute_admin_cmd() handler just like as bdev-ns and
    file-ns. (I don't think so that is what you mean).

OR

2. Split the nvme_alloc_request() into nvme_alloc_request_qid_any() and
    nvme_alloc_request_qid() then call nvme_alloc_request_qid_any() from
    passthru fast path ? (or variation of the same).

OR

Can you please elaborate how you like to have a split ?



More information about the Linux-nvme mailing list