[PATCH V2 04/12] nvmet: use consistent type for op_flag

Christoph Hellwig hch at lst.de
Thu Sep 3 12:20:17 EDT 2020


On Mon, Aug 31, 2020 at 03:26:59PM -0700, Chaitanya Kulkarni wrote:
> In function nvmet_passthru_map_sg() we set the bio->bi_opf ored with
> req_op and op_flags set based on the NVMe cmd. The variable bio->bi_opf
> is declared as unsigned int use same type for op_flag.
> 
> Also, adjust the order according to new length.
> 
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>
> Reviewed By: Logan Gunthorpe <logang at deltatee.com>

Actually all the op_flags used here are bogus and have no meaning for
passthrough commands.  So the right fix is to remove op_flags entirely.



More information about the Linux-nvme mailing list