[PATCH V2 08/12] nvmet: move get/put ctrl into dev open/release

Sagi Grimberg sagi at grimberg.me
Tue Sep 1 13:18:23 EDT 2020


>> @@ -3327,6 +3337,7 @@ static long nvme_dev_ioctl(struct file *file, unsigned int cmd,
>>   static const struct file_operations nvme_dev_fops = {
>>   	.owner		= THIS_MODULE,
>>   	.open		= nvme_dev_open,
>> +	.release	= nvme_dev_release,
>>   	.unlocked_ioctl	= nvme_dev_ioctl,
>>   	.compat_ioctl	= compat_ptr_ioctl,
>>   };
> 
> Seems like everything above this is necessary and fixes a real and
> obvious bug and should go in separately, first.
> 
> Everything below this is rather unrelated to the bug...

Lets overall split bug fixes from any enhancement. Bug fixes
should go directly before we handle enhancements.



More information about the Linux-nvme mailing list