[PATCH] nvme: set passthrough command gendisk

Christoph Hellwig hch at lst.de
Thu Oct 15 13:59:43 EDT 2020


On Thu, Oct 15, 2020 at 07:45:48AM -0700, Keith Busch wrote:
> On Thu, Oct 15, 2020 at 09:42:22AM +0200, Christoph Hellwig wrote:
> > On Wed, Oct 14, 2020 at 01:38:45PM -0700, Keith Busch wrote:
> > > The nvme event traces for IO commands are reporting the wrong QID
> > > because we never set the request's gendisk. Set this parameter if the
> > > passthrough command is being sent through an IO queue.
> > 
> > Why do we event need the check for a non-NULL disk in nvme_req_qid?
> 
> It's the criteria we use to know if we're tracing an Admin vs IO
> command. I suppose we could change the criteria we check rather than set
> the disk parameter. Maybe rq->queue->queuedata instead of rq->bd_disk.
> Would you prefer that?

Yes, I think that makes much more sense.



More information about the Linux-nvme mailing list