[PATCH 17/20] nvme: query namespae identifiers before adding the namespace

[Christoph Hellwig]

On Wed, Sep 30, 2020 at 10:04:54AM +0000, Niklas Cassel wrote:
> > For the subject of this patch:
> > s/namespae/namespace

Fixed and force pushed.

> > nvme: remove the namespace identifier verification in __nvme_validate_ns
> > 
> > None of the identifiers (including the new CSI) can cange over the life
> > time of a namespace, so don't bother with the extra query here.
> > "
> > 
> > which now seems to have been squashed with this patch.
> > 
> > Squashing it is fine, but perhaps you could add that information in this
> > commit message?
> 
> Hm..
> 
> I now see that nvme_validate_or_alloc_ns() in v2 of this series does a
> nvme_identify_ns_descs(), while nvme_validate_or_alloc_ns() in v1 doesnt.
> 
> I don't see a change log, but considering this, my suggestion that you
> the above sentence from the squashed v1 commit no longer makes sense.
> 
> What was the reason for this change?

Where does this this still show up in a change log?

The isn't much point in checking the changing identifiers, but we pretty
much get it for free, so..