[PATCH] nvme-core: update NS Attr Changed AEN handling for ANA group

[George, Martin]

On Mon, 2020-11-23 at 11:43 -0800, Keith Busch wrote:
> On Mon, Nov 23, 2020 at 07:29:05PM +0000, George, Martin wrote:
> > On Mon, 2020-11-23 at 11:16 -0800, Sagi Grimberg wrote:
> > > This looks like a good simple solution to me...
> > > 
> > > > ---
> > > > diff --git a/drivers/nvme/host/multipath.c
> > > > b/drivers/nvme/host/multipath.c
> > > > index 74896be40c17..300cff8c616d 100644
> > > > --- a/drivers/nvme/host/multipath.c
> > > > +++ b/drivers/nvme/host/multipath.c
> > > > @@ -667,6 +667,8 @@ void nvme_mpath_add_disk(struct nvme_ns
> > > > *ns,
> > > > struct nvme_id_ns *id)
> > > >               if (desc.state) {
> > > >                       /* found the group desc: update */
> > > >                       nvme_update_ns_ana_state(&desc, ns);
> > > > +             } else {
> > > > +                     nvme_read_ana_log(ctrl);
> > 
> > Shouldn't this be nvme_read_ana_log(ns->ctrl)?
> 
> Oops, I just did a quick copy-paste. You are correct.

If there is no further feedback, could we move ahead with this fix? Or
does it need to be sent as a separate patch first?

-Martin