[PATCH V7 1/4] nvme: centralize setting req timeout

Christoph Hellwig hch at lst.de
Fri Nov 6 09:16:03 EST 2020


On Thu, Nov 05, 2020 at 03:28:29PM -0800, Chaitanya Kulkarni wrote:
> -	req->timeout = timeout ? timeout : ADMIN_TIMEOUT;
> +	req->timeout = timeout ? timeout : req->timeout;

Nit:  I think

	if (timeout)
		req->timeout = timeout;

reads much better.  Same for the other spots.  If we don't find other issues
I can just fix this up, though.



More information about the Linux-nvme mailing list