[PATCH v3] nvme: fix identify error status silent ignore

Christoph Hellwig hch at lst.de
Mon Jun 29 02:43:49 EDT 2020


On Fri, Jun 26, 2020 at 10:46:29AM -0700, Sagi Grimberg wrote:
> Patch 59c7c3caaaf8 intended to only silently ignore
> non retry-able errors (DNR bit set) such that we can still
> identify misbehaving controllers, and in the other hand
> propagate retry-able errors (DNR bit cleared) so we don't
> wrongly abandon a namespace just because it happens to be
> temporarily inaccessible.
> 
> The goal remains the same as the original commit where this
> was introduced but unfortunately had the logic backwards.

So how did this work all the time?  I'm really worried that someone
this is actually going to break things.  What do you think about
only queueing it up for 5.9 for now?



More information about the Linux-nvme mailing list