[PATCH] nvme: fix identify error status silent ignore

Christoph Hellwig hch at lst.de
Fri Jun 26 04:24:37 EDT 2020


On Wed, Jun 24, 2020 at 05:02:57PM -0700, Sagi Grimberg wrote:
> Patch 59c7c3caaaf8 intended to only silently ignore
> non retry-able errors (DNR bit set) such that we can still
> identify misbehaving controllers, and in the other hand
> propagate retry-able errors (DNR bit cleared) so we don't
> wrongly abandon a namespace just because it happens to be
> temporarily inaccessible.
> 
> The goal remains the same as the original commit where this
> was introduced but unfortunately had the logic backwards.

This probably also needs to be added to the comment to explain WTF is
going on here..



More information about the Linux-nvme mailing list