[PATCH v2 rfc 1/3] nvme: split nvme_remove_namespaces

Christoph Hellwig hch at lst.de
Tue Jul 14 07:06:35 EDT 2020


On Thu, Jul 09, 2020 at 09:35:13PM -0700, Sagi Grimberg wrote:
>> I find the split rather confusing.  So I looked into alternatives
>> and found that the state change should just be a no-op for the PCIe
>> reset case.
>
> Looks like the original version, but the only thing that bothers me
> is that in the reset handler, if we failed to setup any I/O queues,
> we'll put the state in DELETING_NOIO while it's not deleting, I think
> that the point of allowing this is to have the device still up for the
> user to analyze and debug it.

Based on the state machine we can't really move from that state to
DELETING_NOIO as indicated in the comment I added, can we?



More information about the Linux-nvme mailing list