[PATCH 1/4] nvme-core: use macro for ctrl page size default value

Chaitanya Kulkarni Chaitanya.Kulkarni at wdc.com
Wed Jul 8 19:28:17 EDT 2020


On 7/8/20 15:23, Keith Busch wrote:
> On Tue, Jul 07, 2020 at 05:58:28PM -0700, Chaitanya Kulkarni wrote:
>> This is a preparation patch which is needed to centralize the page shift
>> value for the have ctrl->page_size.
> At this point I would recommend removing 'page_size' from 'struct ctrl'
> and use a #define NVME_PAGE_SIZE in its place. There hasn't been any
> attempt to work with different page sizes so I don't see much reason
> for keeping the older code to support it. As an added bonus, a constant
> simplifies several calculations in the io path.
> 
Sounds good. I'll send a V2.



More information about the Linux-nvme mailing list