[PATCH] nvme-pci: use standard block status symbolic names to check return value

Baolin Wang baolin.wang at linux.alibaba.com
Wed Jul 8 02:17:20 EDT 2020


On Wed, Jul 08, 2020 at 07:09:00AM +0200, Christoph Hellwig wrote:
> On Wed, Jul 08, 2020 at 10:18:01AM +0800, Baolin Wang wrote:
> > It's better to use the same symbol as the return to check return value,
> > and will always work in the unlikely event that the defines are reordered.
> > 
> > Suggested-by: Keith Busch <kbusch at kernel.org>
> > Signed-off-by: Baolin Wang <baolin.wang at linux.alibaba.com>
> 
> I'm really not sure this is worth it.  When designing the blk_status_t
> type keeping 0 as was a deliberate design decision.

OK. But there are some places use the BLK_STS_OK to validate, and some
places not in this driver, so I think we should keep code consistent?




More information about the Linux-nvme mailing list