[PATCH 3/3] nvme: don't call revalidate_disk from nvme_set_queue_dying

[Hannes Reinecke]

On 8/23/20 11:10 AM, Christoph Hellwig wrote:
> In nvme_set_queue_dying we really just want to ensure the disk and bdev
> sizes are set to zero.  Going through revalidate_disk leads to a somewhat
> arcance and complex callchain relying on special behavior in a few
> places.  Instead just lift the set_capacity directly to
> nvme_set_queue_dying, and rename and move the nvme_mpath_update_disk_size
> helper so that we can use it in nvme_set_queue_dying to propagate the
> size to the bdev without detours.
> 
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> ---
>  drivers/nvme/host/core.c | 33 +++++++++++++++++++++++----------
>  drivers/nvme/host/nvme.h | 13 -------------
>  2 files changed, 23 insertions(+), 23 deletions(-)
> 
YES!
I've been bitten by this far too often.

Reviewed-by: Hannes Reinecke <hare at suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		           Kernel Storage Architect
hare at suse.de			                  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer