[PATCH v3 2/9] nvme-fabrics: allow to queue requests for live queues
Christoph Hellwig
hch at lst.de
Fri Aug 21 02:22:17 EDT 2020
On Thu, Aug 20, 2020 at 01:45:50PM -0700, James Smart wrote:
> I still dislike any random ioctls coming in while we're still initializing
> the controller.
Agreed.
> Looking at the flow - I wouldn't want them to be allowed
> until after nvme_init_identify() is complete. Especially if the ioctls are
> doing subsystem or controller dumping or using commands that should be
> capped by values set by nvme_queue_limits(). But, if we're going to
> allow nvme_init_identify the admin_q needs to be unquiesced.
>
> So I'm still voting for the admin queue exception.
And I really don't like the admin queue special case. What is the
advantage of letting user space passthrough I/O commands in at this
point in time?
More information about the Linux-nvme
mailing list