[PATCH] nvmet: Set ctrl->kato to a default NVMET_DISC_KATO value

Sagi Grimberg sagi at grimberg.me
Wed Aug 19 11:24:00 EDT 2020


> Actually the spec says that NVME/TCP requires keep alive so it shouldn’t be 0.

Nothing in this language requires it. The keyword should means advice.

> Maybe we do need to set a default value in case of zero kato value ?

No, the patch is fine.

> NVMe-oF 1.1:
> 7.4.8 Keep Alive
> The NVMe/TCP Transport requires the use of the Keep Alive feature (refer to section 7.12 in the NVMe base specification). The NVMe/TCP Transport does not impose any limitations on the minimum and maximum Keep Alive Timeout value. The minimum should be set large enough to account for any transient fabric interconnect failures between the host and controller.
> TCP level Keep Alive functionality is not prohibited but it is recommended that TCP level Keep Alive timeout is set to a higher value than the NVMe Keep Alive Timeout to avoid conflicting policies.



More information about the Linux-nvme mailing list