[PATCH 4/4] nvme: redirect commands on dying queue

[Christoph Hellwig]

On Wed, Aug 19, 2020 at 06:01:46PM +0800, Chao Leng wrote:
> Do not use blk_noretry_request. The local retry mechanism, which is
> defined by nvme protocol, is conflicted with REQ_FAILFAST_TRANSPORT.
> blk_noretry_request is not a good choice for nvme, even for SCSI,
> this is not a good choice too, so SCSI does not use this MACRO.
> We can seperate REQ_FAILFAST_TRANSPORT with other FAILFAST flag.
> For REQ_FAILFAST_TRANSPORT, do local retry for non path error.
> For other FAILFAST flag, complete request with error code immediately.

As said before - please prepare a series removing blk_noretry_request,
and fixing up any lose ends, with a good explanation of what in-tree
supported use case this fixes for you.  Out of tree modules are
completely unsupported, as is ANA with dm-multipath.