[PATCH v7 1/6] net: introduce helper sendpage_ok() in include/linux/net.h
Coly Li
colyli at suse.de
Wed Aug 19 00:22:05 EDT 2020
On 2020/8/19 03:49, Christoph Hellwig wrote:
> On Wed, Aug 19, 2020 at 12:33:37AM +0800, Coly Li wrote:
>> On 2020/8/19 00:24, Christoph Hellwig wrote:
>>> I think we should go for something simple like this instead:
>>
>> This idea is fine to me. Should a warning message be through here? IMHO
>> the driver still sends an improper page in, fix it in silence is too
>> kind or over nice to the buggy driver(s).
>
> I don't think a warning is a good idea. An API that does the right
> thing underneath and doesn't require boiler plate code in most callers
> is the right API.
>
Then I don't have more comment.
Thanks.
Coly Li
More information about the Linux-nvme
mailing list