[PATCH] nvmet: Set ctrl->kato to a default NVMET_DISC_KATO value
Sagi Grimberg
sagi at grimberg.me
Tue Aug 18 16:54:24 EDT 2020
>> We want to avoid starting the keep-alive timer with a zero timeout value
>
> So looking at the spec:
>
> "This field specifies the timeout value for the Keep Alive feature in
> milliseconds. The controller rounds up the value specified to the granularity
> indicated in the KAS
> field in the Identify Controller data structure. If cleared to 0h, then the
> Keep Alive Timer is disabled."
>
> we should not just set a random high timeout but just disable the
> keep alive entirely.
It is already disabled, not sure I understand the patch:
--
static void nvme_start_keep_alive(struct nvme_ctrl *ctrl)
{
if (unlikely(ctrl->kato == 0))
return;
queue_delayed_work(nvme_wq, &ctrl->ka_work, ctrl->kato * HZ);
}
--
More information about the Linux-nvme
mailing list