keep-alive timeout zero value

Engel, Amit Amit.Engel at Dell.com
Mon Aug 17 12:19:36 EDT 2020


Hi,

keep-alive timeout is allowed (by spec) to be set to 0h
In this case, the timer will be started ('nvmet_start_keep_alive_timer') where ctrl->kato = 0.
This will lead to an immediate timer expiration

We thought that in case of a zero keep alive timeout,
ctrl->kato should be set to a default NVMET_DISC_KATO value
(core.c , 'nvmet_alloc_ctrl')
this way we will avoid stating the timer with a zero timeout value
(This is correct for both NVME_NQN_DISC and NVME_NQN_NVME)

What are your thoughts?

Thanks
Amit Engel




More information about the Linux-nvme mailing list