[PATCH 2/4] nvme: refactor command completion

Mike Snitzer snitzer at redhat.com
Mon Aug 17 11:08:36 EDT 2020


On Mon, Aug 17 2020 at  4:15am -0400,
Christoph Hellwig <hch at lst.de> wrote:

> Lift all the code to decide the dispostition of a completed command
> from nvme_complete_rq and nvme_failover_req into a new helper, which
> returns an emum of the potential actions.  nvme_complete_rq then
> just switches on those and calls the proper helper for the action.
> 
> Signed-off-by: Christoph Hellwig <hch at lst.de>

Great work, really like this. Think it will help keep NVMe error
handling robust and more approachable if some unexplained behaviour
occurs in future.

Reviewed-by: Mike Snitzer <snitzer at redhat.com>




More information about the Linux-nvme mailing list