[PATCH 07/14] nvmet: reuse pt-req-done for rq completion

[hch at lst.de]

On Mon, Aug 10, 2020 at 11:02:01PM +0000, Chaitanya Kulkarni wrote:
> On 8/10/20 15:10, Logan Gunthorpe wrote:
> > Christoph had specifically requested open coding this in earlier feedback:
> > 
> > https://lore.kernel.org/linux-block/20191010123406.GC28921@lst.de/
> > 
> > It was originally called nvmet_passthru_req_complete() and was open
> > coded at his request.
> > 
> > I think the way it was merged ended up being cleaner and easier to read
> > as well.
> > 
> > Logan
> 
> I don't understand the reason for this ? Christoph can you please explain ?

Because this just happens to be a few lines of code that looks the
same.  But they are called from different context - one is a callback
and thus has an extra argument for example.  I don't see how sharing
that code really improves anything.